Skip to content

fix(azurite): fix lint #3453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 23, 2025
Merged

fix(azurite): fix lint #3453

merged 1 commit into from
Oct 23, 2025

Conversation

@mdelapenya
Copy link
Member

@mdelapenya mdelapenya commented Oct 23, 2025

What does this PR do?

Removes nolint:staticcheck to satify the linter

Why is it important?

It was causing failures on PRs that needs to build all the modules.

Related issues

@mdelapenya mdelapenya requested a review from a team as a code owner October 23, 2025 15:37
@mdelapenya mdelapenya added the chore Changes that do not impact the existing functionality label Oct 23, 2025
@mdelapenya mdelapenya self-assigned this Oct 23, 2025
@netlify
Copy link

netlify bot commented Oct 23, 2025 •
edited
Loading

✅ Deploy Preview for testcontainers-go ready!

Name Link
🔨 Latest commit 4a665df
🔍 Latest deploy log https://app.netlify.com/projects/testcontainers-go/deploys/68fa4ba997fd58000880d48e
😎 Deploy Preview https://deploy-preview-3453--testcontainers-go.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai
Copy link

coderabbitai bot commented Oct 23, 2025 •
edited
Loading

Summary by CodeRabbit

  • Chores
    • Removed internal lint suppressions from deprecated constants and type alias declarations. No functional changes or user-facing impact.

Walkthrough

Removed inline lint suppression comments (nolint:staticcheck) from deprecated constants and type aliases in the Azurite module. The deprecation declarations remain unchanged; only decorator comments were deleted to clean up code documentation.

Changes

Cohort / File(s) Change Summary
Lint suppression cleanup
modules/azurite/services.go		 Removed inline nolint:staticcheck deprecation lint suppression comments from deprecated constants (BlobService, QueueService, TableService) and the deprecated Service type alias; no functional code modifications

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 Hop, hop—the lint suppressors fade,
Deprecated markers on parade,
Cleaner code, less clutter here,
Comments gone, the path is clear! ✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The title "fix(azurite): fix lint" is directly related to the changeset, which involves removing nolint:staticcheck annotations from the azurite services module to address linter failures. The title clearly identifies both the module (azurite) and the nature of the change (a lint-related fix). While the wording "fix lint" is somewhat generic and doesn't specify that it's about removing suppressions rather than modifying code, it still conveys meaningful information about the changeset and allows a teammate scanning history to understand the general intent of the change.
Description Check ✅ Passed The pull request description is clearly related to the changeset, explaining that it removes nolint:staticcheck annotations to satisfy the linter and addressing failures that occur when building all modules. The description provides context about the motivation (linter failures during module builds) and references a related PR (#3437), directly aligning with the summary of changes that involve removing lint suppression comments from deprecated declarations in the azurite services module.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 32220d6 and 4a665df.

📒 Files selected for processing (1)
  • modules/azurite/services.go (0 hunks)
💤 Files with no reviewable changes (1)
  • modules/azurite/services.go
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: lint (modules/azurite) / lint: modules/azurite
  • GitHub Check: Analyze (go)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@mdelapenya mdelapenya merged commit dd93a61 into testcontainers:main Oct 23, 2025
16 checks passed
@mdelapenya mdelapenya deleted the fix-azurite branch October 23, 2025 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@mdelapenya mdelapenya

Labels

chore Changes that do not impact the existing functionality

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@mdelapenya